fix: update context to "makeCtx func() context.Context" #15584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #15584 +/- ##
==========================================
- Coverage 67.11% 67.11% -0.01%
==========================================
Files 925 925
Lines 76979 76980 +1
Branches 2260 2260
==========================================
- Hits 51667 51663 -4
- Misses 21359 21364 +5
Partials 3953 3953
Flags with carried forward coverage won't be shown. Click here to find out more.
|
heww
approved these changes
Sep 13, 2021
lindhe
pushed a commit
to lindhe/harbor
that referenced
this pull request
Sep 22, 2021
Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Co-authored-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
prahaladdarkin
pushed a commit
to prahaladdarkin/harbor
that referenced
this pull request
Nov 12, 2021
Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Co-authored-by: Shengwen Yu <yshengwen@vmware.com>
prahaladdarkin
pushed a commit
to prahaladdarkin/harbor
that referenced
this pull request
Mar 13, 2022
Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Co-authored-by: Shengwen Yu <yshengwen@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shengwen Yu yshengwen@vmware.com