[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook log #15756

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: webhook log #15756

merged 1 commit into from
Oct 13, 2021

Conversation

zyyw
Copy link
Contributor
@zyyw zyyw commented Oct 11, 2021

Signed-off-by: Shengwen Yu yshengwen@vmware.com

Close: #15686

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw requested review from bitsf and wy65701436 October 11, 2021 11:35
@zyyw
Copy link
Contributor Author
zyyw commented Oct 11, 2021

the log output is changed to the following based on this PR code change:
Oct 11 11:19:07 ubuntu1 core[3209]: 2021-10-11T11:19:07Z [INFO] [/pkg/notifier/notifier.go:205]: Handle notification with Handler 'P2PPreheat' on topic 'SCANNING_COMPLETED': Artifact-&{NamespaceID:1 Repository:library/nginx/1.13.12 Tag:latest Digest:sha256:e4f0474a75c510f40b37b6b7dc2516241ffa8bde5a442bde3d372c9519c84d90 MimeType:application/vnd.docker.distribution.manifest.v2+json} Operator-auto OccurAt-2021-10-11 11:19:07 Oct 11 11:19:07 ubuntu1 core[3209]: 2021-10-11T11:19:07Z [INFO] [/pkg/notifier/notifier.go:205]: Handle notification with Handler 'ScanWebhook' on topic 'SCANNING_COMPLETED': Artifact-&{NamespaceID:1 Repository:library/nginx/1.13.12 Tag:latest Digest:sha256:e4f0474a75c510f40b37b6b7dc2516241ffa8bde5a442bde3d372c9519c84d90 MimeType:application/vnd.docker.distribution.manifest.v2+json} Operator-auto OccurAt-2021-10-11 11:19:07 Oct 11 11:19:07 ubuntu1 core[3209]: 2021-10-11T11:19:07Z [INFO] [/pkg/notifier/notifier.go:205]: Handle notification with Handler 'HTTP' on topic 'http': &{PolicyID:1 EventType:SCANNING_COMPLETED Target:0xc0027dc400 Payload:0xc0010a80f0}

@codecov
Copy link
codecov bot commented Oct 11, 2021

Codecov Report

Merging #15756 (c8c5099) into master (5c92b2f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15756      +/-   ##
==========================================
- Coverage   66.87%   66.86%   -0.02%     
==========================================
  Files         935      935              
  Lines       77657    77657              
  Branches     2294     2294              
==========================================
- Hits        51935    51924      -11     
- Misses      21720    21732      +12     
+ Partials     4002     4001       -1     
Flag Coverage Δ
unittests 66.86% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/notifier/notifier.go 81.70% <100.00%> (ø)
...ortal/src/app/shared/pipes/harbor-datetime.pipe.ts 50.00% <0.00%> (-25.00%) ⬇️
src/lib/cache/helper.go 73.91% <0.00%> (-8.70%) ⬇️
src/common/utils/passports.go 84.61% <0.00%> (-5.13%) ⬇️
...es/vulnerability/vulnerability-config.component.ts 50.79% <0.00%> (-4.77%) ⬇️
...tegration/tag-retention/tag-retention.component.ts 29.95% <0.00%> (-2.21%) ⬇️
src/core/api/internal.go 53.33% <0.00%> (+13.33%) ⬆️

Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 4d89c84 into goharbor:master Oct 13, 2021
prahaladdarkin pushed a commit to prahaladdarkin/harbor that referenced this pull request Nov 12, 2021
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>

Co-authored-by: Shengwen Yu <yshengwen@vmware.com>
prahaladdarkin pushed a commit to prahaladdarkin/harbor that referenced this pull request Mar 13, 2022
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>

Co-authored-by: Shengwen Yu <yshengwen@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCANNING_COMPLETED webhook log is bad
3 participants