-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add current_time to the response of systeminfo api when user logged in #16205
Conversation
Codecov Report
@@ Coverage Diff @@
## main #16205 +/- ##
=======================================
Coverage 66.95% 66.96%
=======================================
Files 945 945
Lines 78521 78538 +17
Branches 2304 2304
=======================================
+ Hits 52576 52594 +18
- Misses 21891 21892 +1
+ Partials 4054 4052 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9f08137
to
d6e135a
Compare
@@ -50,6 +51,7 @@ type Data struct { | |||
} | |||
|
|||
type protectedData struct { | |||
CurrentTime time.Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it is an protected data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the current_time is only added to the response of systeminfo API when user is logged in.
…gged in Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
d6e135a
to
b7af0f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes: #16200
Signed-off-by: Shengwen Yu yshengwen@vmware.com