feat: add current_time to the response of systeminfo api when user logged in #16205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16205 +/- ##
=======================================
Coverage 66.95% 66.96%
=======================================
Files 945 945
Lines 78521 78538 +17
Branches 2304 2304
=======================================
+ Hits 52576 52594 +18
- Misses 21891 21892 +1
+ Partials 4054 4052 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9f08137
to
d6e135a
Compare
wy65701436
reviewed
Jan 11, 2022
| @@ -50,6 +51,7 @@ type Data struct { | |||
| } | |||
|
|
|||
| type protectedData struct { | |||
| CurrentTime time.Time | |||
There was a problem hiding this comment.
why it is an protected data?
There was a problem hiding this comment.
because the current_time is only added to the response of systeminfo API when user is logged in.
…gged in Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
d6e135a
to
b7af0f1
Compare
AllForNothing
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16200
Signed-off-by: Shengwen Yu yshengwen@vmware.com