[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set tag pull time for proxy cache #18731

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

wy65701436
Copy link
Contributor
@wy65701436 wy65701436 commented May 24, 2023

fixes #18708

to set the pull time of tag for the first time cache the artifact.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link
codecov bot commented May 24, 2023

Codecov Report

Merging #18731 (b8feee1) into main (135ca37) will increase coverage by 0.00%.
The diff coverage is 30.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18731   +/-   ##
=======================================
  Coverage   67.38%   67.39%           
=======================================
  Files         980      980           
  Lines      106739   106749   +10     
  Branches     2665     2665           
=======================================
+ Hits        71929    71943   +14     
+ Misses      30945    30942    -3     
+ Partials     3865     3864    -1     
Flag Coverage Δ
unittests 67.39% <30.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/artifact/controller.go 61.77% <0.00%> (ø)
src/controller/proxy/controller.go 14.91% <0.00%> (-0.79%) ⬇️
src/controller/tag/controller.go 75.39% <66.66%> (+0.19%) ⬆️

... and 5 files with indirect coverage changes

fixes goharbor#18708

to set the pull time of tag for the first time cache the artifact.

Signed-off-by: Wang Yan <wangyan@vmware.com>
@wy65701436 wy65701436 merged commit 06aa87a into goharbor:main May 26, 2023
11 of 12 checks passed
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
fixes goharbor#18708

to set the pull time of tag for the first time cache the artifact.

Signed-off-by: Wang Yan <wangyan@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
fixes goharbor#18708

to set the pull time of tag for the first time cache the artifact.

Signed-off-by: Wang Yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pull time of proxy cache artifact should not be empty
5 participants