[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go 1.20.7 && install git for p4 base golang image #19138

Merged
merged 1 commit into from
Aug 14, 2023
Merged

bump go 1.20.7 && install git for p4 base golang image #19138

merged 1 commit into from
Aug 14, 2023

Conversation

MinerYang
Copy link
Contributor
@MinerYang MinerYang commented Aug 9, 2023 •
edited
Loading

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes ##19149

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang requested a review from a team as a code owner August 9, 2023 08:29
@codecov
Copy link
codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #19138 (96d5b4c) into release-2.8.0 (36c452b) will increase coverage by 3.15%.
The diff coverage is n/a.

❗ Current head 96d5b4c differs from pull request most recent head 8afd10e. Consider uploading reports for the commit 8afd10e to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19138      +/-   ##
=================================================
+ Coverage          67.38%   70.54%   +3.15%     
=================================================
  Files                984      749     -235     
  Lines             107027    93936   -13091     
  Branches            2671        0    -2671     
=================================================
- Hits               72119    66263    -5856     
+ Misses             31028    24086    -6942     
+ Partials            3880     3587     -293
Flag Coverage Δ
unittests 70.54% <ø> (+3.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 239 files with indirect coverage changes

@MinerYang
bump go 1.20.7 && install git for p4 base golang image
8afd10e 
Signed-off-by: yminer <yminer@vmware.com>

upadte docker file

Signed-off-by: yminer <yminer@vmware.com>
wy65701436
wy65701436 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit adf8c73 into goharbor:release-2.8.0 Aug 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

Assignees

@wy65701436 wy65701436

@YangJiao0817 YangJiao0817

Labels
release-note/update Update or Fix target/2.8.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MinerYang @wy65701436 @YangJiao0817 @AllForNothing @chlins