[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] refactor: migrate the redis command keys to scan #19147

Merged
merged 1 commit into from
Aug 15, 2023
Merged

[cherry-pick] refactor: migrate the redis command keys to scan #19147

merged 1 commit into from
Aug 15, 2023

Conversation

chlins
Copy link
Member
@chlins chlins commented Aug 10, 2023 •
edited by zyyw
Loading

Refine the cache interface, migrate the Keys to Scan, change the redis underlying keys command to scan.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins
refactor: migrate the redis command keys to scan
a83ce8a 
Refine the cache interface, migrate the Keys to Scan, change the redis
underlying keys command to scan.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins requested a review from a team as a code owner August 10, 2023 04:00
@codecov
Copy link
codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #19147 (a83ce8a) into release-2.8.0 (36c452b) will decrease coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19147      +/-   ##
=================================================
- Coverage          67.38%   67.37%   -0.02%     
=================================================
  Files                984      984              
  Lines             107027   107051      +24     
  Branches            2671     2671              
=================================================
+ Hits               72119    72124       +5     
- Misses             31028    31050      +22     
+ Partials            3880     3877       -3
Flag Coverage Δ
unittests 67.37% <76.92%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lib/cache/cache.go 92.68% <ø> (-7.32%) ⬇️
src/pkg/cached/project_metadata/redis/manager.go 46.37% <0.00%> (ø)
src/pkg/cached/base_manager.go 40.00% <36.36%> (-2.86%) ⬇️
src/lib/cache/redis/redis.go 69.91% <77.77%> (+0.54%) ⬆️
src/lib/cache/memory/memory.go 89.65% <100.00%> (+6.09%) ⬆️
src/pkg/task/dao/execution.go 61.35% <100.00%> (+0.53%) ⬆️

... and 5 files with indirect coverage changes

wy65701436
wy65701436 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 3f10872 into goharbor:release-2.8.0 Aug 15, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@stonezdj stonezdj

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

@MinerYang MinerYang

Labels
release-note/update Update or Fix target/2.8.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chlins @stonezdj @wy65701436 @OrlinVasilev @MinerYang