[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isValidDuration function #19843

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Update isValidDuration function #19843

merged 1 commit into from
Jan 17, 2024

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/robot-account release-note/enhancement Label to mark PR to be added under release notes as enhancement labels Jan 15, 2024
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner January 15, 2024 06:07
@YangJiao0817 YangJiao0817 self-assigned this Jan 15, 2024
@codecov Codecov
Copy link
codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e0f6cc) 70.64% compared to head (c67c0ce) 45.30%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19843       +/-   ##
===========================================
- Coverage   70.64%   45.30%   -25.35%     
===========================================
  Files         747      244      -503     
  Lines       95839    13332    -82507     
  Branches        0     2720     +2720     
===========================================
- Hits        67709     6040    -61669     
+ Misses      24465     6992    -17473     
+ Partials     3665      300     -3365
Flag Coverage Δ
unittests 45.30% <ø> (-25.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 991 files with indirect coverage changes

wy65701436
wy65701436 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 force-pushed the fix-robot-duration branch 2 times, most recently from 43da246 to b933664 Compare January 15, 2024 06:50
@YangJiao0817 YangJiao0817 added release-note/update Update or Fix and removed release-note/enhancement Label to mark PR to be added under release notes as enhancement labels Jan 15, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) January 15, 2024 14:39
@YangJiao0817
Update isValidDuration function
c67c0ce 
Signed-off-by: Yang Jiao <yang.jiao@broadcom.com>
@Vad1mo Vad1mo merged commit 308c6cf into goharbor:main Jan 17, 2024
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
@YangJiao0817
Update isValidDuration function (goharbor#19843)
9d8c636 
Signed-off-by: Yang Jiao <yang.jiao@broadcom.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@stonezdj stonezdj

@wy65701436 wy65701436

@YangJiao0817 YangJiao0817

Labels
area/robot-account release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@YangJiao0817 @stonezdj @wy65701436 @Vad1mo @zyyw @chlins @MinerYang