[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up version to v2.8.5 #20041

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Bump up version to v2.8.5 #20041

merged 1 commit into from
Feb 27, 2024

Conversation

zyyw
Copy link
Contributor
@zyyw zyyw commented Feb 27, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw
Bump up version to v2.8.5
458dd91 
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw added the release-note/ignore-for-release Do not include PR or Issue for release notes label Feb 27, 2024
@zyyw zyyw requested a review from a team as a code owner February 27, 2024 07:57
@codecov Codecov
Copy link
codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.36%. Comparing base (cc32816) to head (458dd91).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #20041      +/-   ##
=================================================
- Coverage          67.38%   67.36%   -0.02%     
=================================================
  Files                984      984              
  Lines             107102   107102              
  Branches            2671     2671              
=================================================
- Hits               72167    72147      -20     
- Misses             31053    31074      +21     
+ Partials            3882     3881       -1
Flag Coverage Δ
unittests 67.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

wy65701436
wy65701436 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 93bdcf5 into goharbor:release-2.8.0 Feb 27, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@MinerYang MinerYang MinerYang approved these changes

Assignees

@stonezdj stonezdj

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

@AllForNothing AllForNothing

@MinerYang MinerYang

Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zyyw @wy65701436 @MinerYang @stonezdj @OrlinVasilev @AllForNothing