feat: add tc for limited guest of a project to get repository #20311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
512c0dd
to
b2e78f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20311 +/- ##
===========================================
- Coverage 67.56% 46.28% -21.29%
===========================================
Files 991 247 -744
Lines 109181 13750 -95431
Branches 2719 2827 +108
===========================================
- Hits 73768 6364 -67404
+ Misses 31449 7062 -24387
+ Partials 3964 324 -3640
Flags with carried forward coverage won't be shown. Click here to find out more. |
| #3. Add user(UA) as a member of project(PA) with "Limited Guest" role; | ||
| with created_project(metadata={"public": "false"}, user_id=user_id, member_role_id=5) as (project_id, project_name): | ||
| #4. Push an image to project(PA) by user(UA), then check the project quota usage; | ||
| image, tag = "goharbor/alpine", "3.10" |
There was a problem hiding this comment.
We can define these variables in setUp.
Comment on lines
+56
to
+57
| #6. Delete repository(RA) | ||
| self.repository.delete_repository(project_name, "goharbor%2Falpine", **ADMIN_CLIENT) |
There was a problem hiding this comment.
Maybe this step should be in tearDown.
There was a problem hiding this comment.
it has to be within the with created_project, otherwise with created_project cannot delete the project itself because there is repository within the project to be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #19878
Please indicate you've done the following: