[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Add sbom_report table to store sbom related information #20482

Merged
merged 1 commit into from
May 24, 2024
Merged

[cherry-pick] Add sbom_report table to store sbom related information #20482

merged 1 commit into from
May 24, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20445
Refactor scan/base_controller.go
Move MakeReportPlaceholder, GetReportPlaceholder, GetSummary to vul and sbom scanHandler

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj
Add sbom_report table to store sbom related information
0601013 
  fixes goharbor#20445
  Refactor scan/base_controller.go
  Move MakeReportPlaceholder, GetReportPlaceholder, GetSummary to vul and sbom scanHandler

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj requested a review from a team as a code owner May 24, 2024 08:44
@stonezdj stonezdj assigned wy65701436 and unassigned Vad1mo, zyyw and MinerYang May 24, 2024
@stonezdj stonezdj requested a review from zyyw May 24, 2024 08:44
@stonezdj stonezdj requested a review from wy65701436 May 24, 2024 08:45
@stonezdj stonezdj changed the title Add sbom_report table to store sbom related information [cherry-pick] Add sbom_report table to store sbom related information May 24, 2024
wy65701436
wy65701436 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov Codecov
Copy link
codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@a763d6b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20482   +/-   ##
=================================================
  Coverage                  ?   46.26%           
=================================================
  Files                     ?      247           
  Lines                     ?    13770           
  Branches                  ?     2842           
=================================================
  Hits                      ?     6371           
  Misses                    ?     7072           
  Partials                  ?      327
Flag Coverage Δ
unittests 46.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@stonezdj stonezdj merged commit e282686 into goharbor:release-2.11.0 May 24, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@wy65701436 wy65701436

@zyyw zyyw

Labels
release-note/update Update or Fix target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stonezdj @wy65701436 @zyyw @Vad1mo @MinerYang