[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls support for pushing sbom #20515

Merged
merged 1 commit into from
May 30, 2024
Merged

tls support for pushing sbom #20515

merged 1 commit into from
May 30, 2024

Conversation

wy65701436
Copy link
Contributor

Make it supports the tls configuration for the client for pushing sbom object

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner May 29, 2024 09:52
@codecov Codecov
Copy link
codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-2.11.0@723abc6). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20515   +/-   ##
=================================================
  Coverage                  ?   69.00%           
=================================================
  Files                     ?      798           
  Lines                     ?    99708           
  Branches                  ?        0           
=================================================
  Hits                      ?    68801           
  Misses                    ?    27125           
  Partials                  ?     3782
Flag Coverage Δ
unittests 69.00% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/util.go 57.14% <25.00%> (ø)

github-advanced-security[bot]
github-advanced-security bot found potential problems May 29, 2024
View reviewed changes
src/pkg/scan/util.go Fixed Show fixed Hide fixed
@wy65701436 wy65701436 force-pushed the release-2.11.0-cp-20514 branch 2 times, most recently from 151bf12 to c67d63c Compare May 29, 2024 10:19
@wy65701436
tls support for pushing sbom
0e84942 
Make it supports the tls configuration for the client for pushing sbom object

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 enabled auto-merge (squash) May 30, 2024 05:40
@wy65701436 wy65701436 disabled auto-merge May 30, 2024 05:42
@stonezdj stonezdj merged commit 614bf40 into goharbor:release-2.11.0 May 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@Vad1mo Vad1mo

@stonezdj stonezdj

@zyyw zyyw

@MinerYang MinerYang

Labels
release-note/update Update or Fix target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wy65701436 @stonezdj @zyyw @Vad1mo @MinerYang