[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix http client to push sbom accessory #20525

Merged
merged 1 commit into from
May 31, 2024
Merged

fix http client to push sbom accessory #20525

merged 1 commit into from
May 31, 2024

Conversation

wy65701436
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436
fix http client to push sbom accessory
2f2e1bd 
Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 requested a review from a team as a code owner May 31, 2024 07:26
@wy65701436 wy65701436 added the release-note/update Update or Fix label May 31, 2024
@codecov Codecov
Copy link
codecov bot commented May 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.26%. Comparing base (b7b8847) to head (2f2e1bd).
Report is 206 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20525      +/-   ##
==========================================
- Coverage   67.56%   66.26%   -1.30%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113477    +4296     
  Branches     2719     2844     +125     
==========================================
+ Hits        73768    75198    +1430     
- Misses      31449    34171    +2722     
- Partials     3964     4108     +144
Flag Coverage Δ
unittests 66.26% <100.00%> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/util.go 64.00% <100.00%> (ø)

... and 572 files with indirect coverage changes

@wy65701436 wy65701436 merged commit 7645ec7 into goharbor:main May 31, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@stonezdj stonezdj

@zyyw zyyw

@OrlinVasilev OrlinVasilev

@AllForNothing AllForNothing

@MinerYang MinerYang

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wy65701436 @stonezdj @zyyw @OrlinVasilev @AllForNothing @MinerYang