[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the execution sweep sql to resolve the exec deletion conflict #20603

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix: update the execution sweep sql to resolve the exec deletion conflict #20603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1d54d1
fix: update the execution sweep sql to resolve the exec deleteion con…
chlins Jun 17, 2024
9420cc7
Merge branch 'main' into fix/execution-sweep-deletion
wy65701436 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pkg/task/sweep_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
return errors.Wrap(err, "failed to delete tasks")
}
// delete executions
sql = fmt.Sprintf("DELETE FROM execution WHERE id IN (%s)", orm.ParamPlaceholderForIn(len(params)))
sql = fmt.Sprintf("DELETE FROM execution WHERE id IN (%s) AND id NOT IN (SELECT DISTINCT execution_id FROM task)", orm.ParamPlaceholderForIn(len(params)))

Check warning on line 179 in src/pkg/task/sweep_manager.go

View check run for this annotation

Codecov / codecov/patch

src/pkg/task/sweep_manager.go#L179 

Added line #L179 was not covered by tests
_, err = ormer.Raw(sql, params...).Exec()
if err != nil {
return errors.Wrap(err, "failed to delete executions")
Expand Down
Loading