[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for undefined in horizontal flyout layout function #7522

Closed
1 task done
rachel-fenichel opened this issue Sep 22, 2023 · 7 comments · Fixed by #7537
Closed
1 task done

Check for undefined in horizontal flyout layout function #7522

rachel-fenichel opened this issue Sep 22, 2023 · 7 comments · Fixed by #7537
Assignees
@priya-rjb
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ issue: bug Describes why the code or behaviour is wrong

Comments

@rachel-fenichel
Copy link
Collaborator
rachel-fenichel commented Sep 22, 2023 •
edited
Loading

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

In layout_ in flyout_horizontal.ts we access the block with const block = item.block. The result is nullable, so all later uses of block have to have a non-null assertion

To fix:

  • Check whether block is undefined after setting const block = item.block.
  • continue if block doesn't exist.
  • Remove ! from after the remaining uses of block within the for loop.

To get set up for this issue:

  • Run npm install from the root of the repository.
  • Run npm run build from the root of the repository.
  • Run npm run start to launch the test playground.
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Sep 22, 2023
@rachel-fenichel rachel-fenichel mentioned this issue Sep 22, 2023
Closed
1 task
@BeksOmega BeksOmega added ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ and removed rrf-internal labels Sep 22, 2023
@SophieNguyen113
Copy link
Contributor
SophieNguyen113 commented Sep 22, 2023 •
edited
Loading

:>

@TroySigX
Copy link

I'd love to work on this

@juhithaVd
Copy link

I want to work on this

@rachel-fenichel
Copy link
Collaborator Author

Thanks for your interest! This is being worked on in the blockly-dragon breakout room.

@juhithaVd
Copy link

Does that mean any of us can do the issue?

@rachel-fenichel
Copy link
Collaborator Author

Please join the breakout room to see what the status is and who is working on this.

@priya-rjb
Copy link
Contributor

Hi, we are currently in the breakout room and would like to be assigned this code as we made progress. Thanks!

priya-rjb added a commit to priya-rjb/blockly that referenced this issue Sep 22, 2023
@priya-rjb
google#7522 edits -- collaborated with Hinal Patel, Swedhaa Sri Elang…
7bccb2c 
…o, & Yuchi Hsieh
@priya-rjb priya-rjb mentioned this issue Sep 22, 2023
Merged
1 task
priya-rjb added a commit to priya-rjb/blockly that referenced this issue Sep 22, 2023
@priya-rjb
google#7522 edits: collaborated with Hinal Patel, Swedhaa Sri Elango,…
c7d18a9 
… & Yuchi Hsieh
priya-rjb added a commit to priya-rjb/blockly that referenced this issue Sep 22, 2023
@priya-rjb
fix: non-nullable check for block variable and removed ! in layout_ g…
ce92e99 
…oogle#7522
johnnesky pushed a commit that referenced this issue Sep 24, 2023
@priya-rjb
fix: non-nullable check for block variable and removed ! in layout_ #…
c762d42 
…7522 (#7537)

* #7522 edits -- collaborated with Hinal Patel, Swedhaa Sri Elango, & Yuchi Hsieh

* #7522 edits: collaborated with Hinal Patel, Swedhaa Sri Elango, & Yuchi Hsieh

* fix: non-nullable check for block variable and removed ! in layout_ #7522

* fix: non-nullable check for block variable and removed ! in layout_
@cpcallen cpcallen removed the issue: triage Issues awaiting triage by a Blockly team member label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priya-rjb priya-rjb

Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ issue: bug Describes why the code or behaviour is wrong
Projects
No open projects
Blockly GHC OSD
Status: Done Testing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: non-nullable check for block variable and removed ! in layout_ #7522 priya-rjb/blockly
7 participants
@cpcallen @rachel-fenichel @BeksOmega @TroySigX @juhithaVd @SophieNguyen113 @priya-rjb