feat: make ICopyable generic and update clipboard APIs #7348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
reviewed
Aug 2, 2023
maribethb
approved these changes
Aug 3, 2023
| U extends ICopyData, | ||
| T extends ICopyable<U> & IHasWorkspace, | ||
| >(toDuplicate: T): T | null { | ||
| deprecation.warn( |
There was a problem hiding this comment.
would rather not add the deprecation warning until you've fixed the internal usages, but since this is going into a feature branch and not directly into the release i won't stop you
There was a problem hiding this comment.
I have a draft PR fixing all internal usages :D #7352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7337
Proposed Changes
ICopyableinterface to be generic.clipboardAPIs to take in data instead of being stateful.pastepublic. Everything else remains internal.Reason for Changes
Test Coverage
Now that the methods aren't stateful anymore, I could test the API boundary between the clipboard and pasters :D
Documentation
N/A
Additional Information
N/A
Deprecations
Blockly.clipboard.copyandBlockly.clipboard.duplicatehave both been deprecated. These were marked@internalso if you are conforming to Blockly's API, you should not be accessing them anyway.Blockly.clipboard.copycan be replaced with callingtoCopyDataon the element you want to copy.Blockly.clipboard.duplicatecan be replaced by callingBlockly.clipboard.paste(myElement.toCopyData(), myWorkspace).