deprecate: workspace paste #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
3a57814
to
454a617
Compare
cpcallen
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes N/A
Proposed Changes
Deprecates the
pastefunction on the workspace.Reason for Changes
This function is not maintainable. It is hard coded to deserialize block data and workspace comment data. It cannot be backwards compatibily updated to use the new paster system, because it doesn't takes in the save state instead of the
CopyDatadirectly.I see no reason to maintain this when we have better functionality in
clipboard.paste.For now it will continue to work as it did before (no breaking changes). But it will be deleted in v12.
Test Coverage
N/A This is just a deprecation :P
Documentation
N/A
Additional Information
N/A