feat: make generator quoting methods public #7392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
reviewed
Aug 14, 2023
d3ba7ca
to
f038d51
Compare
f038d51
to
00f4bb4
Compare
|
@cpcallen This is ready for rereview =) [Edit: nvm, needs edits in response to https://github.com//issues/7326#issuecomment-1681298070 ] |
rachel-fenichel
approved these changes
Aug 19, 2023
It looks like this is no longer true, so please remove from the description before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #7326
Proposed Changes
Makes the
quote_andmultiline_quote_methods public.Reason for Changes
quote_andmultiline_quote_were previously inaccessible to external developers. They can now be accessed inside block-code generators just like they are in core.Test Coverage
N/A
Documentation
This is for some documentation :D
Additional Information
N/A