The basics

• I validated my changes

The details

Resolves

Fixes #6008 and works on #7326

Proposed Changes

• Adds getVariableName and getProcedureName APIs to CodeGenerator class.
• Makes nameDB_ public to account for use cases not served by the above APIs.
• Updated block-code generators to call the new APIs instead of accessing nameDB_ directly.
• Updated the block-code generator functions for procedure definition blocks in python and php to use for...of instead of funky for loop; this improves the typing information (while these files are not in TS yet, editors are still able to use the TS information for better autosuggest)

Behavior Before Change

The only way to get these, which you need to do inside block-code generator functions, was to access the (previously protected) nameDB_ object.

Behavior After Change

• New APIs can be used for variable and procedure names, which covers the two most common use cases for needing to access nameDB_. The advantage of these methods is that it prints a warning if nameDB_ has not been initialized, which is a common failure mode we've seen in the forums.
• Niche use cases (developer variables, temporary variables with distinct names) can access nameDB_ directly.

Reason for Changes

Improved developer APIs and documentation

Test Coverage

Added some basic unit tests. The Names db functionality has its own tests, so just stubbed that out.

Documentation

Beka currently has a doc in progress that would touch this
cc @BeksOmega

Additional Information