fix: dragging blocks within a zoomed mutator #7423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a browser test for this? |
Verdict is no, the error does not replicate when dragging with webdriver. I'm going to split my fixes to the mutator tests into a separate PR though, cuz I think those are valuable on their own. |
4d3661b
to
512a841
Compare
NeilFraser
approved these changes
Aug 24, 2023
1 task
This was referenced Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7421
Proposed Changes
Sets
internalIsMutatoron the mini workspace bubble workspace.Reason for Changes
Makes it so that dragging behaves correctly.
Test Coverage
Manually tested dragging with a zoomed workspace.
Documentation
N/A
Additional Information
N/A