fix: Addition of the .gitattributes file to standardize line endings #7517
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
-
You can find tips about contributing to Blockly and how to
validate your changes on our
developer site. -
All contributors must sign the Google Contributor License
Agreement (CLA). If the google-cla bot leaves a comment on this
PR, make sure you follow the instructions. -
We use conventional commits
to make versioning the package easier. Make sure your commit
message is in the proper format
or learn how to fix it. -
If any of the other checks on this PR fail, you can click on
them to learn why. It might be that your change caused a test
failure, or that you need to double-check the
style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
There was a problem hiding this comment.
Hi @sam301100 Thank you for opening this PR! It needs just a few changes before it can be merged:
- All contributors need to sign the CLA; you can follow googlebot's instructions in the comment it left to sign the CLA and refresh the check
- Update your PR title to start with
fix:so that our tools can properly categorize this PR as a fix - Address the comment left in the PR review
After you take care of these few things we'll be able to merge your PR! Thank you!
|
Hi @maribethb, Thank you, |
Description:
fixes #7191
Overview:
This pull request addresses the issue reported in #7191 by adding a .gitattributes file to standardize line endings within the Blockly project.
Changes:
Added a .gitattributes file with the following configuration to ensure consistent line endings:
Motivation:
Standardizing line endings to LF (Unix-style) is essential for maintaining code consistency across different platforms and prevents issues related to mixed line endings when collaborating on projects.
Testing:
I have tested these changes locally by cloning the repository and verifying that the .gitattributes file is properly applied to the project. Line endings are consistent with LF, as expected.
...
Thank you for considering this pull request. I'm excited to contribute to the Blockly project during the Grace Hopper Celebration 2023 Open Source Day. Please let me know if there are any additional changes or improvements needed for this contribution.