[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move delete keyboard shortcut in-progress gesture check to precondition #6274 #7528

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: move delete keyboard shortcut in-progress gesture check to precondition #6274 #7528

merged 1 commit into from
Sep 22, 2023

Conversation

humera811
Copy link
Contributor
@humera811 humera811 commented Sep 22, 2023 •
edited
Loading

The basics

The details

Resolves

Proposed Changes

  • Add a check to the precondition function to make sure a gesture is not in progress.
  • Remove the gesture check

Reason for Changes

-The delete keyboard shortcut was checking if there is a gesture in progress from within its callback function, and returns early if so which should not have been the case

Test Coverage

Documentation

Additional Information

@humera811 humera811 requested a review from a team as a code owner September 22, 2023 19:41
@google-cla
Copy link
google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link
conventional-commit-lint-gcf bot commented Sep 22, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

github-actions[bot]
github-actions bot reviewed Sep 22, 2023
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to
    validate your changes on our
    developer site.

  • All contributors must sign the Google Contributor License
    Agreement (CLA). If the google-cla bot leaves a comment on this
    PR, make sure you follow the instructions.

  • We use conventional commits
    to make versioning the package easier. Make sure your commit
    message is in the proper format
    or learn how to fix it.

  • If any of the other checks on this PR fail, you can click on
    them to learn why. It might be that your change caused a test
    failure, or that you need to double-check the
    style guide.

Thank you for opening this PR! A member of the Blockly team will review it soon.

@debaraj-barua
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

@humera811 To fix this, you could either change the commit message using:

 git commit --amend -m "fix #6274: Move delete keyboard shortcut in-progress gesture check to precondition" 
 git push --force origin fixes

or any message you feel is appropriate

or just add the automerge label as suggested

Additionally, in your PR description, under

Resolves

    Fixes Move delete keyboard shortcut in-progress gesture check to precondition

you could also add a link to the issue like

Resolves

    Fixes #6274: Move delete keyboard shortcut in-progress gesture check to precondition

That should auto-link this PR to the issue.

@rachel-fenichel
Copy link
Collaborator

🎉 Thanks for contributing!

@rachel-fenichel rachel-fenichel changed the title [Fixes]-Move delete keyboard shortcut in-progress gesture check to precondition #6274 fix: move delete keyboard shortcut in-progress gesture check to precondition #6274 Sep 22, 2023
@github-actions github-actions bot added the PR: fix Fixes a bug label Sep 22, 2023
@rachel-fenichel rachel-fenichel merged commit a488973 into google:osd Sep 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

@maribethb maribethb Awaiting requested review from maribethb maribethb is a code owner automatically assigned from google/blockly-eng

Assignees

@maribethb maribethb

Labels
PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move delete keyboard shortcut in-progress gesture check to precondition
4 participants
@humera811 @debaraj-barua @rachel-fenichel @maribethb