[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: made the method isDragTowardWorkspace non private #7529

Merged
merged 7 commits into from
Sep 22, 2023
Merged

feat: made the method isDragTowardWorkspace non private #7529

merged 7 commits into from
Sep 22, 2023

Conversation

ramyaram2092
Copy link
Contributor

The basics

The details

Resolves

Fixes 7462

Proposed Changes

I have removed @internal tag from flyout_horizontal.ts and flyout_vertical.ts files

Reason for Changes

made the method non -private to create custom layouts

Test Coverage

Documentation

Additional Information

@ramyaram2092 ramyaram2092 requested a review from a team as a code owner September 22, 2023 20:02
@ramyaram2092 ramyaram2092 changed the title feat : Made the method isDragTowardWorkspace non private #7527 feat : Made the method isDragTowardWorkspace non private Sep 22, 2023
@ramyaram2092 ramyaram2092 changed the title feat : Made the method isDragTowardWorkspace non private feat : made the method isDragTowardWorkspace non private Sep 22, 2023
@johnnesky johnnesky changed the title feat : made the method isDragTowardWorkspace non private feat: made the method isDragTowardWorkspace non private Sep 22, 2023
@github-actions github-actions bot added the PR: feature Adds a feature label Sep 22, 2023
johnnesky
johnnesky requested changes Sep 22, 2023
View reviewed changes
core/flyout_vertical.ts Outdated Show resolved Hide resolved
@johnnesky
Copy link
Member

Excellent, thank you for the great work!

@johnnesky johnnesky merged commit 4437fdb into google:osd Sep 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnesky johnnesky johnnesky approved these changes

Assignees

@johnnesky johnnesky

Labels
PR: feature Adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove @internal tag from isDragTowardWorkspace
2 participants
@ramyaram2092 @johnnesky