fix: removed underscore from isLabel_ in flyout_button.ts #7533
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
-
You can find tips about contributing to Blockly and how to
validate your changes on our
developer site. -
All contributors must sign the Google Contributor License
Agreement (CLA). If the google-cla bot leaves a comment on this
PR, make sure you follow the instructions. -
We use conventional commits
to make versioning the package easier. Make sure your commit
message is in the proper format
or learn how to fix it. -
If any of the other checks on this PR fail, you can click on
them to learn why. It might be that your change caused a test
failure, or that you need to double-check the
style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
core/flyout_button.ts
Outdated
| @@ -227,8 +227,8 @@ export class FlyoutButton { | |||
| } | |||
|
|
|||
| /** @returns Whether or not the button is a label. */ | |||
| isLabel(): boolean { | |||
| return this.isLabel_; | |||
| isButtonLabel(): boolean { | |||
There was a problem hiding this comment.
Aha, this must be why we didn't make this change before. The isLabel method is public, so we don't want to rename it.
Instead, please change isLabel_ -> isFlyoutLabel.
Sorry for the wrong instructions!
There was a problem hiding this comment.
Hey Rachel,
Thank you so much for your review.
I made the necessary changes and pushed them.
Could you please take a look once?
Thanks,
Sayali
|
Thanks! Two things left:
|
c28a210
to
eb2651d
Compare
|
@rachel-fenichel I think this is good to go! |
|
🥳 Thanks @sayalikandarkar! |
|
Thank you so much @rachel-fenichel for all your feedback :) |
The basics
The details
Resolves
Fixes #7526
Proposed Changes
This pr renames the incorrectly labeled variable and removes underscore from it precisely
Reason for Changes
Test Coverage
I did npm run and tested all the buttons before and after and checked the entire functionality once
I have attached a screenshot of the working functionality after making the changes
Documentation
I don't believe any additional documentation is requiredAdditional Information