[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add muted option #7714

Merged
merged 6 commits into from
Jan 11, 2024
Merged

feat: add muted option #7714

merged 6 commits into from
Jan 11, 2024

Conversation

truongductri01
Copy link
Contributor

The basics

I am not sure how to set up a virtual workspace and test the audio yet

The details

Resolves

Fixes: #7669

Proposed Changes

Reason for Changes

Test Coverage

Documentation

Additional Information

@github-actions github-actions bot added the PR: feature Adds a feature label Dec 13, 2023
@truongductri01 truongductri01 marked this pull request as ready for review December 13, 2023 02:06
@truongductri01 truongductri01 requested a review from a team as a code owner December 13, 2023 02:06
@truongductri01 truongductri01 marked this pull request as draft December 13, 2023 02:06
@truongductri01 truongductri01 mentioned this pull request Dec 13, 2023
Closed
1 task
@BeksOmega
Copy link
Collaborator

Heya @truongductri01 let me know when you've had a chance to test this, then I'll give it a review =)

@BeksOmega
Copy link
Collaborator

Heya @truongductri01 are you still interested in working on this? I'll check back in a week and close it if not!

@truongductri01
Copy link
Contributor Author

Heya @truongductri01 are you still interested in working on this? I'll check back in a week and close it if not!

Hi @BeksOmega , I am so sorry for the late response. I have tried to test it in the playground demo but really not sure how to call the setMuted on the workspace to mute the sound. Could you give me a hint?

@BeksOmega
Copy link
Collaborator

Hi @BeksOmega , I am so sorry for the late response. I have tried to test it in the playground demo but really not sure how to call the setMuted on the workspace to mute the sound. Could you give me a hint?

Can you send what you tried based on my previous comment?

@truongductri01
Copy link
Contributor Author

Hi @BeksOmega , I am so sorry for the late response. I have tried to test it in the playground demo but really not sure how to call the setMuted on the workspace to mute the sound. Could you give me a hint?

Can you send what you tried based on my previous comment?

Actually, I have found the way to test it. Using this code workspace.audioManager.setMuted(true); I have been able to disable the sound of the workspace.

@BeksOmega BeksOmega marked this pull request as ready for review January 10, 2024 17:04
BeksOmega
BeksOmega requested changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator
@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this looks great!

Just a few changes to docs then I think this should be good to go =)

core/workspace_audio.ts Outdated Show resolved Hide resolved
core/workspace_audio.ts Outdated Show resolved Hide resolved
core/workspace_audio.ts Outdated Show resolved Hide resolved
core/workspace_audio.ts Outdated Show resolved Hide resolved
truongductri01 and others added 4 commits January 11, 2024 08:11
@truongductri01 @BeksOmega
Update core/workspace_audio.ts
4a6c0e4 
Co-authored-by: Beka Westberg <bwestberg@google.com>
@truongductri01 @BeksOmega
Update core/workspace_audio.ts
1a94abf 
Co-authored-by: Beka Westberg <bwestberg@google.com>
@truongductri01 @BeksOmega
Update core/workspace_audio.ts
ed81010 
Co-authored-by: Beka Westberg <bwestberg@google.com>
@truongductri01 @BeksOmega
Update core/workspace_audio.ts
2c1005e 
Co-authored-by: Beka Westberg <bwestberg@google.com>
@truongductri01
Copy link
Contributor Author

Tested and this looks great!

Just a few changes to docs then I think this should be good to go =)

I make the commits based on your suggestions. Let me know if something else needed to be done

@BeksOmega BeksOmega merged commit 7243b48 into google:develop Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
PR: feature Adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to mute Blockly audio
2 participants
@truongductri01 @BeksOmega