fix: shouldPreventMove not being respected #7894

BeksOmega · 2024-02-28T19:38:43Z

The basics

Fixes N/A

#4886 never actually worked.

Makes it so that shouldPreventMove is actually respected.

Manually tested by linking to the backpack plugin.

Dragging an orphaned block moves it back to the old location on the workspace.
Dragging a child block reattaches it to parent.
Dragging a parent block (holding ctrl to heal stack) reattaches to child.
Dragging a middle block (holding ctrl to heal stack) reattaches to parent and child.
Dragging from the simple flyout toolbox bumps blocks into bounds.

N/A

I'm going to release a beta of 10.5 for this for app inventor so they can test with it.

ewpatton · 2024-02-29T01:34:52Z

I've tested with the beta version @BeksOmega sent and we have deployed in our Blockly update test server.

core/block_dragger.ts

fix: shouldPreventMove not being respected

5175f56

BeksOmega requested a review from a team as a code owner February 28, 2024 19:38

BeksOmega requested a review from rachel-fenichel February 28, 2024 19:38

github-actions bot assigned rachel-fenichel Feb 28, 2024

github-actions bot added the PR: fix Fixes a bug label Feb 28, 2024

rachel-fenichel reviewed Mar 5, 2024

View reviewed changes

core/block_dragger.ts Outdated Show resolved Hide resolved

core/block_dragger.ts Outdated Show resolved Hide resolved

fix: PR comments

9a7ec3a

rachel-fenichel approved these changes Mar 6, 2024

View reviewed changes

BeksOmega merged commit 7c7dfd0 into google:develop Mar 7, 2024
6 checks passed