fix: connection dancing #7899
Merged
fix: connection dancing #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cpcallen
approved these changes
Mar 8, 2024
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Mar 8, 2024
* fix: special case zelos for connection previewing * chore: add TODO (cherry picked from commit 848415e)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
"Fixes" #7898 by not having zelos use insertion blocks for inputs and outputs (instead we just highlight). Going to leave a comment on that issue with a more proper fix we should do in the future.
Test Coverage
Manually tested that zelos shows insertion markers for stack blocks.
Manually tested that zelos does not show insertion markers for row blocks.
Manually tested that geras shows insertion markers in all cases.
Documentation
N/A
Additional Information
We should release a patch for this.