fix!: have Lua generators use 'nil' instead of 'None' #7837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7e20f6
to
772df29
Compare
rachel-fenichel
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #6720
Proposed Changes
Makes it so that lua generators use 'nil' instead of 'None'. Reasoning is explained in the linked issue.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A
Breaking changes
This may break some user's downstream block programs if they are assigning to a variable called 'None' and then initializing lists with empty inputs expecting them to contain the value assigned to
None.It is unlikely that this behavior was ever actually discovered, and as such the correction shouldn't affect end-users.