fix(typings): Restore inadvertently-deleted typings/msg/msg.d.ts; add TS import test
#7955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#7952. The main typings file for langfiles, typings/msg/msg.d.ts, was inadvertently deleted in PR google#7822. This was part of a well intentioned attempt to remove spurious files from typings/msg/ that do not correspond to published langfiles, but this file should have been retained because msg.d.ts is reexported by all the other *.d.ts files in this directory.
NeilFraser
approved these changes
Mar 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details
Resolves
Fixes #7952
Proposed Changes
Restore main typings file for langfiles,
typings/msg/msg.d.ts, which was inadvertently deleted in PR #7822.Reason for Changes
Imports of
blockly/msg/*are broken; this fixes them.Test Coverage
Added a test that would have caught this mistake had it existed before now.
Additional Information
The deletion was part of a well intentioned attempt to remove spurious files from
typings/msg/that did not correspond to published langfiles, butmsg.d.tsshould have been retained because it is reexported by all the other*.d.tsfiles in this directory.