feat: rendered workspace comment #7918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be4eab2
to
1fffaaa
Compare
1fffaaa
to
3f88daf
Compare
0c1fa59
to
7e6068c
Compare
NeilFraser
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7907
Proposed Changes + Reasons
Adds an extremely basic rendered workspace comment class.
Test Coverage
Manually tested that everything is connected correctly.
We can't automatically test that the view gets updated correctly since we don't have screenshot testing.
Ensuring that the model gets updated will be covered by future serialization tests.
Documentation
N/A
Additional Information
N/A