[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clear up the orphan mon_groups which are created by cadvisor #3058

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srl11
Copy link
@srl11 srl11 commented Feb 9, 2022

Revival of #3057, handling the orphan mon_groups.
if resctrl_interval!=0, cache the mon_group created by cadvisor, which has cadvisor monGroupPrefix, and clear up the expired mon_group when a new container is being creating.

@Creatone

@k8s-ci-robot
Copy link
Collaborator

Hi @srl11. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@srl11 srl11 force-pushed the f-resctrl-clear-up-orphan-mon_groups branch from 04d703e to 9ff1dd3 Compare February 14, 2022 09:25
@srl11 srl11 marked this pull request as draft February 14, 2022 13:30
@srl11 srl11 force-pushed the f-resctrl-clear-up-orphan-mon_groups branch from 9ff1dd3 to 8e28dba Compare February 14, 2022 13:59
@srl11 srl11 marked this pull request as ready for review February 21, 2022 08:31
@Creatone
Copy link
Collaborator

Why do you keep mon group names? All groups have "cadvisor" prefix.

@srl11
Copy link
Author
srl11 commented Mar 10, 2022

"cadvisor" prefix.

All groups have "cadvisor" prefix, but some of them are still working(by cadvisor, for some case it may used by other program). We can use the name to quickly determine whether the mon_group is out of date, related container has exited, and should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants