[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grpc] Update grpc to fix firebase-ios-sdk/#12441 #10

Merged
merged 3 commits into from
Mar 6, 2024
Merged

[grpc] Update grpc to fix firebase-ios-sdk/#12441 #10

merged 3 commits into from
Mar 6, 2024

Conversation

ncooke3
Copy link
Member
@ncooke3 ncooke3 commented Feb 29, 2024 •
edited
Loading

Test Plan

  • Tested and validated with locally hosted binaries
  • Tested and validated with remotely hosted binaries

See "🎉" in below file tree to emphasize the SPM wrapper resource bundles.

/Users/nickcooke/Library/Developer/Xcode/Archives/2024-02-29/MyCoolApp 2-29-24, 5.29 PM.xcarchive
├── Info.plist
├── Products
│   └── Applications
│       └── MyCoolApp.app
│           ├── AppIcon60x60@2x.png
│           ├── AppIcon76x76@2x~ipad.png
│           ├── Assets.car
│           ├── Firebase_FirebaseCore.bundle
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── Firebase_FirebaseCoreExtension.bundle
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── Firebase_FirebaseCoreInternal.bundle
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── Firebase_FirebaseFirestore.bundle
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── Frameworks
│           │   ├── FirebaseFirestoreInternal.framework
│           │   │   ├── FirebaseFirestoreInternal
│           │   │   ├── FirebaseFirestoreInternal_Privacy.bundle
│           │   │   │   ├── Info.plist
│           │   │   │   └── PrivacyInfo.xcprivacy
│           │   │   ├── Info.plist
│           │   │   └── _CodeSignature
│           │   │       └── CodeResources
│           │   ├── absl.framework 🎯 Notice that Xcode 15.3 embeds
│           │   │   ├── Info.plist
│           │   │   ├── _CodeSignature
│           │   │   │   └── CodeResources
│           │   │   └── absl
│           │   ├── grpc.framework  🎯 Notice that Xcode 15.3 embeds
│           │   │   ├── Info.plist
│           │   │   ├── _CodeSignature
│           │   │   │   └── CodeResources
│           │   │   └── grpc
│           │   ├── grpcpp.framework  🎯 Notice that Xcode 15.3 embeds
│           │   │   ├── Info.plist
│           │   │   ├── _CodeSignature
│           │   │   │   └── CodeResources
│           │   │   └── grpcpp
│           │   └── openssl_grpc.framework  🎯 Notice that Xcode 15.3 embeds
│           │       ├── Info.plist
│           │       ├── _CodeSignature
│           │       │   └── CodeResources
│           │       └── openssl_grpc
│           ├── GoogleUtilities_GoogleUtilities-Privacy.bundle
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── Info.plist
│           ├── MyCoolApp
│           ├── PkgInfo
│           ├── PrivacyInfo.xcprivacy
│           ├── Promises_FBLPromises.bundle
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── _CodeSignature
│           │   └── CodeResources
│           ├── abseil_absl-Wrapper.bundle 🎉
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── embedded.mobileprovision
│           ├── gRPC_grpc-Wrapper.bundle 🎉
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── gRPC_grpcpp-Wrapper.bundle 🎉
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── gRPC_openssl-grpc-Wrapper.bundle 🎉
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           ├── leveldb_leveldb.bundle
│           │   ├── Info.plist
│           │   └── PrivacyInfo.xcprivacy
│           └── nanopb_nanopb.bundle
│               ├── Info.plist
│               └── PrivacyInfo.xcprivacy
├── Signatures
│   ├── FirebaseFirestoreInternal.xcframework-ios.signature
│   ├── absl.xcframework-ios.signature
│   ├── grpc.xcframework-ios.signature
│   ├── grpcpp.xcframework-ios.signature
│   └── openssl_grpc.xcframework-ios.signature
└── dSYMs
    └── MyCoolApp.app.dSYM
        └── Contents
            ├── Info.plist
            └── Resources
                ├── DWARF
                │   └── MyCoolApp
                └── Relocations
                    └── aarch64
                        └── MyCoolApp.yml

37 directories, 59 files

Release Plan

@ncooke3 ncooke3 mentioned this pull request Feb 29, 2024
Merged
paulb777
paulb777 approved these changes Feb 29, 2024
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
ncooke3
ncooke3 commented Feb 29, 2024
View reviewed changes
Package.swift Show resolved Hide resolved
andrewheard
andrewheard approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator
@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the -

@ncooke3 ncooke3 merged commit ea4cb5c into main Mar 6, 2024
1 check passed
@andrewheard andrewheard mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ncooke3 @paulb777 @andrewheard