[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect wiring of the GoogleServicesTask #232

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix incorrect wiring of the GoogleServicesTask #232

merged 1 commit into from
Jun 22, 2022

Commits on Jun 9, 2022

  1. Fix incorrect wiring of the GoogleServicesTask 

    In the process of making configuration of the GooglerServicesTask lazily
configured, the registration of the generated outputs with the Android
Gradle plugin was moved into the lazy task configuration. This only
works if the google services task is configured before any of the tasks
that consume it, which is not guaranteed, leading to the below issues.

This change also removes the partial workaround of manually adding the
task dependency to one of the consuming tasks.

Issue: google#228
Also potentially related: google#228
Test: Manually verified that the wiring works correctly with AGP 7.4.0-alpha03 and Gradle 7.5-rc-1
    @cmwarrington
    cmwarrington committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    8192dfb View commit details
    Browse the repository at this point in the history