[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add region tags for CameraDemoActivity #233

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

barbeau
Copy link
Collaborator
@barbeau barbeau commented Jun 1, 2020

Also made following changes to Java version:

  • Remove Hungarian notation from variables
  • Remove redundant view casts

This replaces the in-line code currently at:
https://developers.google.com/maps/documentation/android-sdk/events#camera_change_events

@arriolac Could you give this a close look? It's the first set of region tags I've added.

Also made following changes to Java version:
* Remove Hungarian notation from variables
* Remove redundant view casts
@barbeau barbeau requested a review from arriolac June 1, 2020 21:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2020
Copy link
Contributor
@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

@barbeau barbeau merged commit a72d0bd into master Jun 2, 2020
@barbeau barbeau deleted the sean/events/camera branch June 2, 2020 15:21
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants