[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure CameraPositionState map reference clears when GoogleMap l… #109

Merged
merged 3 commits into from
May 6, 2022
Merged

fix: Ensure CameraPositionState map reference clears when GoogleMap l… #109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8c5bd0
fix: Ensure CameraPositionState map reference clears when GoogleMap l…
arriolac May 5, 2022
8629553
Adding test for GoogleMap coming in and out of the Composition.
arriolac May 5, 2022
f4bbb9b
PR feedback.
arriolac May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Ensure CameraPositionState map reference clears when GoogleMap l… 
…eaves composition.

Change-Id: Iccf615e1a468ea7fbddb652052cec51b5d98a763
  • Loading branch information
@arriolac
arriolac committed May 5, 2022
commit e8c5bd07c6ac3e5d9a0cd7860b588ff8d454f6f8
8 changes: 8 additions & 0 deletions app/src/androidTest/java/com/google/maps/android/compose/GoogleMapViewTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,14 @@ class GoogleMapViewTests {
assertTrue(mapLoaded)
}

@Test
fun testCameraPositionStateMapClears() {
// TODO(Complete)
// composeTestRule.setContent {
// }
// assertTrue(cameraPositionState.map)
}

private fun zoom(
shouldAnimate: Boolean,
zoomIn: Boolean,
Expand Down
3 changes: 3 additions & 0 deletions maps-compose/src/main/java/com/google/maps/android/compose/MapApplier.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import com.google.android.gms.maps.model.Polyline
internal interface MapNode {
fun onAttached() {}
fun onRemoved() {}
fun onCleared() {}
}

private object MapNodeRoot : MapNode
Expand All @@ -43,6 +44,8 @@ internal class MapApplier(

override fun onClear() {
map.clear()
decorations.forEach { it.onCleared() }
decorations.clear()
}

override fun insertBottomUp(index: Int, instance: MapNode) {
Expand Down