[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Added Address Descriptors to Geocoding response. Refactored Geo… #516

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat!: Added Address Descriptors to Geocoding response. Refactored Geo… #516

wants to merge 3 commits into from

Conversation

tcliff111
Copy link
Collaborator

…coding response to allow fields outside the geocoding result to be exposed through the client.

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ x] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x ] Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [ x] Appropriate docs were updated (if necessary)

Fixes #515 🦕

feat! Added Address Descriptors to Geocoding response. Refactored Geo…
1fbdddf 
…coding response to allow fields outside the geocoding result to be exposed through the client.
wangela
wangela requested changes Feb 29, 2024
View reviewed changes
Copy link
Member
@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a usage example to the README. I will also patch in to add required sections to the README.

@wangela wangela changed the title feat! Added Address Descriptors to Geocoding response. Refactored Geo… feat!: Added Address Descriptors to Geocoding response. Refactored Geo… Feb 29, 2024
Tom Clifford added 2 commits April 5, 2024 12:58
feat! Added Address Descriptors to Geocoding response. Refactored Geo…
f8994e6 
…coding response to allow fields outside the geocoding result to be exposed through the client.
Merge branch 'address_descriptors' of https://github.com/googlemaps/g…
9813c45 
…oogle-maps-services-python into address_descriptors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@wangela wangela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Address Descriptors to Geocoding
2 participants
@tcliff111 @wangela