[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updates advanced marker example maps for GA. #1477

Closed
wants to merge 2 commits into from
Closed

feat: Updates advanced marker example maps for GA. #1477

wants to merge 2 commits into from

Conversation

willum070
Copy link
Contributor
@willum070 willum070 commented Apr 27, 2023 •
edited
Loading

This change does the following:

  • Renames AdvancedMarkerView to AdvancedMarkerElement.
  • Renames PinView to PinElement.
  • Refactors examples to use dynamic library import; removes long namespace names.
  • Variables renamed to make more sense with new member names.
  • Changes SVG in graphics example to not use a Google pin.
  • Removes beta flag in all but one example (it is still required to use the Place class).

Fixes #<issue_number_goes_here> 🦕

@dependabot @willum070
feat: Updates advanced marker example maps for GA.
f52b591 
Change-Id: I1eb0eac8e056716a8202c79285443a7df508411e
@willum070 willum070 closed this May 8, 2023
@willum070
Copy link
Contributor Author

These changes were merged with #1486, closing this PR since it's not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amuramoto amuramoto Awaiting requested review from amuramoto

Assignees

@amuramoto amuramoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willum070 @amuramoto