feat(spanner): add Interval/Timestamp/time-zone operations #14120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
StatusOr<Timestamp> Add(Timestamp const&, Interval const&,
absl::string_view time_zone);
StatusOr<Interval> Diff(Timestamp const&, Timestamp const&,
absl::string_view time_zone);
```
A timestamp and a time zone represent a civil time, to which an Interval
can be added. Similarly, the difference between two such civil times is
an Interval (albeit without a years/months component).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14120 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 2203 2203
Lines 188807 188872 +65
=======================================
+ Hits 176031 176103 +72
+ Misses 12776 12769 -7 ☔ View full report in Codecov by Sentry. |
alevenberg
approved these changes
May 3, 2024
| @@ -247,6 +253,63 @@ TEST(Interval, OutputStreaming) { | |||
| EXPECT_EQ("1 year 2 months 3 days 04:05:06.123456789", os.str()); | |||
| } | |||
|
|
|||
| TEST(Interval, TimestampOperations) { | |||
There was a problem hiding this comment.
nit: might want to separate this into multiple tests, so it is clear what each is testing, but fine to leave as is
There was a problem hiding this comment.
Thanks. I think it is clear enough as to what is being tested. And indeed, it may well be clearer testing these "inverse" operations right next to each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A timestamp and a time zone represent a civil time, to which an Interval can be added. Similarly, the difference between two such civil times is an Interval (albeit without a years/months component).
This change is