[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use bzlmod for asan build #14447

Merged
merged 1 commit into from
Jul 9, 2024
Merged

ci: use bzlmod for asan build #14447

merged 1 commit into from
Jul 9, 2024

Conversation

coryan
Copy link
Member
@coryan coryan commented Jul 9, 2024 •
edited
Loading

The ODR problems are fixed in the Bazel Central Registry modules.

Part of the work for #11485

This change is Reviewable

@coryan
ci: use bzlmod for asan build
d4d931d 
The ODR problems are fixed in the Bazel Central Registry modules.
@codecov Codecov
Copy link
codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (34c4b4c) to head (d4d931d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14447   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2315     2315           
  Lines      207150   207150           
=======================================
  Hits       193879   193879           
  Misses      13271    13271

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 9, 2024 19:32
@coryan coryan requested a review from a team as a code owner July 9, 2024 19:32
scotthart
scotthart approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member
@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 19114db into googleapis:main Jul 9, 2024
64 checks passed
@coryan coryan deleted the ci-use-asan-with-bzlmod branch July 9, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotthart scotthart scotthart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coryan @scotthart