cleanup(storage): inline UndecoratedFromMock() #11708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11708 +/- ##
=======================================
Coverage 83.02% 83.02%
=======================================
Files 1827 1826 -1
Lines 164734 164734
=======================================
+ Hits 136765 136768 +3
+ Misses 27969 27966 -3
☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
May 23, 2023
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1.
Reviewable status: 1 of 4 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from #11613 (reply in thread)
Inline the function while it is only one line, and we have no other need for a source file.
This makes it easier for customers who
#include "google/cloud/storage/testing/mock_client.h"without linking togoogle_cloud_cpp_storage_testingto adopt the new function.This change is