[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oauth2): do not require id_token in creds #12867

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(oauth2): do not require id_token in creds #12867

merged 1 commit into from
Oct 11, 2023

Conversation

MeilakhSiarhei
Copy link
Collaborator
@MeilakhSiarhei MeilakhSiarhei commented Oct 11, 2023 •
edited by coryan
Loading

Only a limited number of scopes returns this field. For the rest of scopes this field is not populated, which is ok.

This change is Reviewable

@MeilakhSiarhei MeilakhSiarhei requested a review from a team as a code owner October 11, 2023 13:57
@coryan coryan changed the title micro: remove the requirement to have id_token in response. fix(oauth2): do not require id_token in creds Oct 11, 2023
@MeilakhSiarhei
Copy link
Collaborator Author

/gcbrun

coryan
coryan reviewed Oct 11, 2023
View reviewed changes
Copy link
Member
@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the tests too, maybe remove this line:

google-cloud-cpp/google/cloud/internal/oauth2_authorized_user_credentials_test.cc

Line 263 in 953aefe

"id_token": "id-token-value",

@coryan
Copy link
Member
coryan commented Oct 11, 2023

And probably this line too:

google-cloud-cpp/google/cloud/internal/oauth2_authorized_user_credentials_test.cc

Line 226 in 953aefe

"id_token": "id-token-value",

@coryan
Copy link
Member
coryan commented Oct 11, 2023

/gcbrun

@MeilakhSiarhei
Copy link
Collaborator Author

I removed those 2 lines.
There is still 'id_token' at line 65. I'm not sure if it's an issue, because sometimes it returns this field.

@coryan
Copy link
Member
coryan commented Oct 11, 2023

I removed those 2 lines. There is still 'id_token' at line 65. I'm not sure if it's an issue, because sometimes it returns this field.

Let's go and remove that too.

@MeilakhSiarhei
micro: remove the requirement to have id_token in response.
8f76295 
Only a limited number of scopes returns this field. For the rest of scopes this field is not populated, which is ok.
@MeilakhSiarhei MeilakhSiarhei temporarily deployed to external October 11, 2023 14:26 — with GitHub Actions Inactive
@coryan
Copy link
Member
coryan commented Oct 11, 2023

/gcbrun

@codecov
Copy link
codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (953aefe) 93.54% compared to head (8f76295) 93.54%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12867   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files        2075     2075           
  Lines      180728   180727    -1     
=======================================
+ Hits       169067   169069    +2     
+ Misses      11661    11658    -3
Files Coverage Δ
...oud/internal/oauth2_authorized_user_credentials.cc 100.00% <ø> (ø)
...nternal/oauth2_authorized_user_credentials_test.cc 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit f81fd55 into googleapis:main Oct 11, 2023
54 checks passed
@MeilakhSiarhei MeilakhSiarhei deleted the id_token_removal branch October 11, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MeilakhSiarhei @coryan