[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update version,changelog for v2.17.0 #12875

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore: update version,changelog for v2.17.0 #12875

merged 2 commits into from
Oct 12, 2023

Conversation

dbolduc
Copy link
Member
@dbolduc dbolduc commented Oct 11, 2023 •
edited by coryan
Loading

This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal October 11, 2023 20:17 — with GitHub Actions Inactive
coryan
coryan approved these changes Oct 11, 2023
View reviewed changes
CHANGELOG.md

### [Compute Engine](/google/cloud/compute/README.md)

- fix(compute): usable in external Bazel projects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include #12877 in this release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I sent the PR optimistically.

@codecov
Copy link
codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ff11eda) 93.54% compared to head (23b0ec3) 93.54%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12875   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files        2075     2075           
  Lines      180754   180754           
=======================================
  Hits       169093   169093           
  Misses      11661    11661

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc force-pushed the changelog-version-bump-v2-17-0 branch from 472d4e1 to 23b0ec3 Compare October 12, 2023 03:21
@dbolduc dbolduc temporarily deployed to internal October 12, 2023 03:21 — with GitHub Actions Inactive
@dbolduc dbolduc marked this pull request as ready for review October 12, 2023 03:21
@dbolduc dbolduc requested a review from a team as a code owner October 12, 2023 03:21
@dbolduc dbolduc merged commit b248f74 into googleapis:main Oct 12, 2023
54 checks passed
@dbolduc dbolduc deleted the changelog-version-bump-v2-17-0 branch October 12, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbolduc @coryan @devbww