[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pubsub): add kinesis sample #13593

Merged
merged 13 commits into from
Mar 15, 2024
Merged

docs(pubsub): add kinesis sample #13593

merged 13 commits into from
Mar 15, 2024

Conversation

alevenberg
Copy link
Member
@alevenberg alevenberg commented Feb 12, 2024 •
edited by coryan
Loading

This change is Reviewable

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Feb 12, 2024
@alevenberg alevenberg added the do not review Indicates a PR is not ready for review label Feb 12, 2024
@alevenberg
Copy link
Member Author

The emulator needs to be updated.

Currently getting

ingestion_data_source_settings.aws_kinesis.gcp_service_account but got 2024-02-12T19:53:26.779777190Z [DEBUG] <140328757732352> UpdateTopic() >> status=INVALID_ARGUMENT: Invalid update_mask provided in the UpdateTopicRequest: ingestion_data_source_settings.aws_kinesis.gcp_service_account is not a known Topic field. Note that field paths must be of the form 'schema_settings' rather than 'schemaSetings'. (google/cloud/internal/log_wrapper.cc:29)

@alevenberg alevenberg added the status: blocked Resolving the issue is dependent on other work. label Feb 16, 2024
@alevenberg alevenberg removed status: blocked Resolving the issue is dependent on other work. do not review Indicates a PR is not ready for review labels Mar 7, 2024
@codecov Codecov
Copy link
codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.17%. Comparing base (77e4fff) to head (1754f51).
Report is 3 commits behind head on main.

Files Patch % Lines
google/cloud/pubsub/samples/topic_admin_samples.cc 95.65% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13593      +/-   ##
==========================================
- Coverage   93.17%   93.17%   -0.01%     
==========================================
  Files        2235     2235              
  Lines      193634   193680      +46     
==========================================
+ Hits       180425   180454      +29     
- Misses      13209    13226      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg
Copy link
Member Author 
Step #5: } (google/cloud/internal/log_wrapper.cc:24)
Step #5: 2024-03-08T19:02:06.763819768Z [DEBUG] <139986183036096> CreateTopic() >> status=NOT_FOUND: Cloud Pub/Sub tried to connect to the ingestion data source but could not find it: Not found; Gaia id not found for email fake-service-account@fake-gcp-project.iam.gserviceaccount.com. (google/cloud/internal/log_wrapper.cc:29)
Step #5: 2024-03-08T19:02:06.764360261Z [DEBUG] <139986183036096> DeleteTopic() << google.pubsub.v1.DeleteTopicRequest {
Step #5:   topic: "projects/cloud-cpp-testing-resources/topics/cloud-cpp-samples-2024-03-08-igbrzaxdlukjxbvcdxebjrkwrfntguwk"
Step #5: } (google/cloud/internal/log_wrapper.cc:24)
Step #5: 2024-03-08T19:02:07.320414091Z [DEBUG] <139986183036096> DeleteTopic() >> status=OK (google/cloud/internal/log_wrapper.cc:29)
Step #5: terminate called after throwing an instance of 'google::cloud::v2_23::Status'

@alevenberg
Copy link
Member Author

Service team says we need to wait till 3/15 for the integration test to pass

@alevenberg alevenberg marked this pull request as ready for review March 15, 2024 21:19
@alevenberg alevenberg requested a review from a team as a code owner March 15, 2024 21:19
@alevenberg
Copy link
Member Author

Ready for review!

@alevenberg alevenberg merged commit d990372 into googleapis:main Mar 15, 2024
62 checks passed
@alevenberg alevenberg deleted the kinesis branch March 15, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alevenberg @coryan