feat(storage): support HNS-enabled buckets #13753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add accessors and modifiers for the `hierarchical_namespace()` field in a bucket. Parse the field in bucket metadata responses for JSON and gRPC. Add support to set this field on create, update, and patch requests. Also for JSON and gRPC. Include and example (which doubles as an integration test), and the usual unit tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13753 +/- ##
========================================
Coverage 93.25% 93.25%
========================================
Files 2233 2235 +2
Lines 193286 193392 +106
========================================
+ Hits 180252 180357 +105
- Misses 13034 13035 +1 ☔ View full report in Codecov by Sentry. |
|
@frankyn or @sydney-munro do you have time to take a look at this? |
scotthart
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add accessors and modifiers for the
hierarchical_namespace()field in a bucket. Parse the field in bucket metadata responses for JSON and gRPC. Add support to set this field on create, update, and patch requests. Also for JSON and gRPC. Include and example (which doubles as an integration test), and the usual unit tests.Part of the work for #13561
This change is