[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: TestIntegration_DML failed #2486

Closed
flaky-bot bot opened this issue Jun 18, 2020 · 1 comment · Fixed by #2509
Closed

spanner: TestIntegration_DML failed #2486

flaky-bot bot opened this issue Jun 18, 2020 · 1 comment · Fixed by #2509
Assignees
Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link
flaky-bot bot commented Jun 18, 2020

Note: #2160 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 7641218
buildURL: Build Status, Sponge
status: failed

@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 18, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 18, 2020
@codyoss codyoss assigned skuruppu and unassigned codyoss Jun 18, 2020
@flaky-bot
Copy link
Author
flaky-bot bot commented Jun 18, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (7641218), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 23, 2020
@olavloite olavloite self-assigned this Jun 24, 2020
olavloite added a commit that referenced this issue Jun 24, 2020
A read/write transaction should always return any error to the
transaction runner and let it determine whether it should be
returned to the user application, or it should cause a transaction
retry. Failing to do so, can cause the transaction to fail
sometimes with an Aborted error.

Fixes #2486
olavloite added a commit that referenced this issue Jun 25, 2020
A read/write transaction should always return any error to the transaction runner and let it determine whether it should be
returned to the user application, or it should cause a transaction retry. Failing to do so, can cause the transaction to fail sometimes with an Aborted error.

Fixes #2486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants