[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(firestore): add GetCommitTime TransactionOption #6967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(firestore): add GetCommitTime TransactionOption #6967

wants to merge 1 commit into from

Conversation

galenwarren
Copy link
@galenwarren galenwarren commented Oct 31, 2022 •
edited
Loading

Adds a new TransactionOption -- GetCommitTime -- that allows the caller to specify the address of a time.Time where the commit time of the transaction should be written, upon successful commit.

@galenwarren galenwarren requested review from enocom, telpirion and a team as code owners October 31, 2022 01:34
@google-cla
Copy link
google-cla bot commented Oct 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the Firestore API. labels Oct 31, 2022
@galenwarren galenwarren mentioned this pull request Oct 31, 2022
Open
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Nov 30, 2022
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Dec 30, 2022
@galenwarren
Copy link
Author

@telpirion @enocom I was just checking on this. Would either of you be able to provide a code review? Thanks.

@enocom
Copy link
Member
enocom commented Mar 30, 2023

Sorry for the slow response @galenwarren. Ownership of this library has changed in the past few months. Let me reach out to some folks and see who should be looking at this.

@galenwarren
Copy link
Author
galenwarren commented Mar 30, 2023 via email

@enocom
Copy link
Member
enocom commented Apr 5, 2023

cc @bhshkh and @kolea2 who might know who should look at this.

@galenwarren
Copy link
Author

@enocom @bhshkh @kolea2 Any update here? Thanks.

@bhshkh
Copy link
Contributor
bhshkh commented Jun 14, 2023

Reviewing

@galenwarren
Copy link
Author

@bhshkh Thanks, please let me know if you have any questions or suggestions.

@galenwarren
Copy link
Author

@bhshkh Hi, just checking in here. Is there any update? Thanks.

@bhshkh
Copy link
Contributor
bhshkh commented Sep 13, 2023

Under discussion internally. Will update

@galenwarren
Copy link
Author

@bhshkh Is there anything I can do here to help?

@galenwarren
Copy link
Author

Is this one not going to get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. size: s Pull request size is small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@galenwarren @enocom @bhshkh