[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: prevent use of transforms as values passed to 'Query.where'. #6703

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Firestore: prevent use of transforms as values passed to 'Query.where'. #6703

merged 2 commits into from
Nov 30, 2018

Conversation

tseaver
Copy link
Contributor
@tseaver tseaver commented Nov 29, 2018

Closes #6699.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Nov 29, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2018
@tseaver
Copy link
Contributor Author
tseaver commented Nov 29, 2018

The Kokoro failure is in an unrelated flaky systest ("Quota exceeded").

@tseaver
Copy link
Contributor Author
tseaver commented Nov 29, 2018

@crwilcox This one should also be ready for review.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2018
@tseaver tseaver merged commit 4fe89c9 into googleapis:master Nov 30, 2018
@tseaver tseaver deleted the 6699-firestore-query_where_w_transforms branch November 30, 2018 22:29
erikwebb pushed a commit to erikwebb/google-cloud-python that referenced this pull request Dec 3, 2018
@tseaver @erikwebb
Prevent use of transforms as values passed to 'Query.where'. (googlea…
76ac80c 
…pis#6703)

Closes googleapis#6699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tseaver @crwilcox @googlebot @yoshi-kokoro