Firestore: impose required semantics for snapshots as cursors. #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Snapshot cursors imply on ordering on '__name__', if not already
present. Implied ordering is added at the end of the list, matching
the direction of the prior entry ('ASCENDING' if none exist).
- Snapshots copy their document reference into the '__name__' field
of their document values.
- Disallow use of snapshots from foreign collections as query cursors.
- In a query with one or more 'where' clauses using ordering operators,
and including a snapshot cursor, we must add ordering on the field(s)
used (IFF the field is not already in the query's 'order_by').
Closes #6665.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot cursors imply on ordering on
__name__, if not already present. Implied ordering is added at the end of the list, matching the direction of the prior entry (ASCENDINGif none exist).Snapshots copy their document reference into the
__name__field of their document values.Disallow use of snapshots from foreign collections as query cursors.
In a query with one or more
whereclauses using ordering operators, and including a snapshot cursor, we must add ordering on the field(s) used (IFF the field is not already in the query'sorder_by).Closes #6665.