[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Add missing transforms to 'google.cloud.firestore' shim. #8481

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Firestore: Add missing transforms to 'google.cloud.firestore' shim. #8481

merged 1 commit into from
Jul 2, 2019

Conversation

tseaver
Copy link
Contributor
@tseaver tseaver commented Jun 26, 2019

Add a unit test that asserts the shim stays in sync with 'google.cloud.firestore_v1'.

Closes #8173.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Jun 26, 2019
@tseaver tseaver requested a review from crwilcox June 26, 2019 19:26
@tseaver tseaver requested a review from frankyn as a code owner June 26, 2019 19:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2019
@tseaver tseaver requested a review from busunkim96 June 26, 2019 22:35
@tseaver
Add missing transforms to 'google.cloud.firestore' shim.
bfc1252 
Add a unit test that asserts the shim stays in sync with
'google.cloud.firestore_v1'.

Closes #8173.
@tseaver
Copy link
Contributor Author
tseaver commented Jul 2, 2019

Rebased to cope with the out-of-date madness.

@tseaver tseaver merged commit 2d7aff4 into googleapis:master Jul 2, 2019
@tseaver tseaver deleted the 8173-firestore-add_new_exports branch July 2, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore: sync shim module with 'firestore_v1' package.
2 participants
@tseaver @googlebot