[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards compatibility in google-api-client #606

Closed
sduskis opened this issue Feb 26, 2019 · 3 comments
Closed

Fix backwards compatibility in google-api-client #606

sduskis opened this issue Feb 26, 2019 · 3 comments
Assignees
@chingor13 @elharo
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@sduskis
Copy link
Contributor
sduskis commented Feb 26, 2019

#543 broke backwards compatibility. (see here for the ripple effect).

#543 broke apart google-api-client into two packages, but removed some public classes. That type of change requires a major semver change.

In the short term, we need to add a dependency in google-http-client to google-http-client-apache to preserve backwards compatibility until we have a major new release of google-http-client.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 27, 2019
@sduskis sduskis added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Feb 28, 2019
@sduskis sduskis mentioned this issue Mar 7, 2019
Closed
@sduskis
Copy link
Contributor Author
sduskis commented Mar 7, 2019 •
edited
Loading

First attempt by adding the dependency:

[ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex{label='com.google.http-client:google-http-client-apache:2.0.1-SNAPSHOT'}' and 'Vertex{label='com.google.http-client:google-http-client:1.28.1-SNAPSHOT'}' introduces to cycle in the graph com.google.http-client:google-http-client:1.28.1-SNAPSHOT --> com.google.http-client:google-http-client-apache:2.0.1-SNAPSHOT --> com.google.http-client:google-http-client:1.28.1-SNAPSHOT @

@elharo
Copy link
Contributor
elharo commented Mar 13, 2019

It looks like there's also a 2.0.0 version of google-http-client-apache. Could we simply revert #543 for 1.29.0?

@sduskis
Copy link
Contributor Author
sduskis commented Mar 13, 2019

I think that we'd have to:

  1. maintain an empty(ish) jar for the new artifact and move the .java files and dependencies back to the original artifact.
  2. release 1.29.0
  3. revert the change and release a new 2.*

@elharo elharo mentioned this issue Mar 14, 2019
Merged
2 tasks
@elharo elharo mentioned this issue Mar 15, 2019
Merged
2 tasks
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
@release-please
chore: release 0.25.3-SNAPSHOT (googleapis#606)
e099038 
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

@elharo elharo

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @sduskis @elharo @yoshi-automation