[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moe sync without linting #410

Merged
merged 5 commits into from
Apr 30, 2018
Merged

Conversation

jeanbza
Copy link
Member
@jeanbza jeanbza commented Apr 30, 2018

This lacks the linting fixes / jdk5->7 / datanucleus changes from #409.

clm and others added 5 commits April 28, 2018 14:13
… public.

This will make custom implementations easier. All other classes in the package
are already public.

Also modified the visibility of AbstractMemoryDataStore.save() from package
private to public.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=174893279
…(...)

where the value will be immediately unboxed anyway.

The change removes small-but-pervasive inefficiencies from creating and
immediately discarding instances of the wrapped value, as well as removing
unnecessary syntax.

More information: go/lsc-immediateunboxing

Tested:
    tap_presubmit: http://test/OCL:189509157:BASE:189708880:1521556795490:d7b0a09a
    Some tests failed; test failures are believed to be unrelated to this CL

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=189880661
When lowLevelHttpRequest is not set via MockHttpTransport.Builder, buildRequest() creates a new instance of MockLowLevelHttpRequest. Due to what seems to be a bug, the newly created MLLHR wasn't saved to MHT instance. That means, getLowLevelHttpRequest() called on such instance returns null, making it impossible to inspect actual request being sent. For example, this bug made it impossible to verify headers of outbound HTTP requests.

This CL mirrors a change in the github repository: googleapis@8b59272

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=193200613
@jeanbza jeanbza requested a review from ejona86 April 30, 2018 23:40
@jeanbza jeanbza merged commit d292606 into googleapis:dev Apr 30, 2018
@jeanbza jeanbza changed the title Moe without linting Moe syc without linting Jun 3, 2018
@jeanbza jeanbza changed the title Moe syc without linting Moe sync without linting Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants